refactor split_generator

ami.py

@@ -263,6 +263,12 @@ _EVAL_SAMPLE_IDS = [
     "TS3003d",
 ]
 
+_SAMPLE_IDS = {
+    "train": _TRAIN_SAMPLE_IDS,
+    "dev": _VALIDATION_SAMPLE_IDS,
+    "eval": _EVAL_SAMPLE_IDS,
+}
+
 _SUBSETS = ("ihm",)
 
 _BASE_DATA_URL = "https://huggingface.co/datasets/edinburghcstr/ami/resolve/main/"
@@ -314,43 +320,49 @@ class AMI(datasets.GeneratorBasedBuilder):
         )
 
     def _split_generators(self, dl_manager):
-        train_audio_files = {m: _AUDIO_ARCHIVE_URL.format(subset=self.config.name, split="train", _id=m) for m in _TRAIN_SAMPLE_IDS}
-        dev_audio_files = {m: _AUDIO_ARCHIVE_URL.format(subset=self.config.name, split="dev", _id=m) for m in _VALIDATION_SAMPLE_IDS}
-        eval_audio_files = {m: _AUDIO_ARCHIVE_URL.format(subset=self.config.name, split="eval", _id=m) for m in _EVAL_SAMPLE_IDS}
+        splits = ["train", "dev", "eval"]
 
-        train_audio_archives = dl_manager.download(train_audio_files)
-        dev_audio_archives = dl_manager.download(dev_audio_files)
-        eval_audio_archives = dl_manager.download(eval_audio_files)
+        audio_archives_urls = {}
+        for split in splits:
+            audio_archives_urls[split] = {
+                m: _AUDIO_ARCHIVE_URL.format(subset=self.config.name, split=split, _id=m) for m in _SAMPLE_IDS[split]
+            }
+        audio_archives = dl_manager.download(audio_archives_urls)
+        local_extracted_archives_paths = dl_manager.extract(audio_archives) if not dl_manager.is_streaming else {
+            split: [None] * len(audio_archives[split]) for split in splits
+        }
 
-        train_annotation = dl_manager.download_and_extract(_ANNOTATIONS_ARCHIVE_URL.format(split="train"))
-        dev_annotation = dl_manager.download_and_extract(_ANNOTATIONS_ARCHIVE_URL.format(split="dev"))
-        eval_annotation = dl_manager.download_and_extract(_ANNOTATIONS_ARCHIVE_URL.format(split="eval"))
+        annotations_urls = {split: _ANNOTATIONS_ARCHIVE_URL.format(split=split) for split in splits}
+        annotations = dl_manager.download(annotations_urls)
 
         return [
             datasets.SplitGenerator(
                 name=datasets.Split.TRAIN,
                 gen_kwargs={
-                    "audio_archives": [dl_manager.iter_archive(archive) for archive in train_audio_archives.values()],
-                    "local_extracted_archives_paths": dl_manager.extract(train_audio_archives).values() if not dl_manager.is_streaming else [None] * len(train_audio_archives),
-                    "annotation": train_annotation,
+                    "audio_archives": [dl_manager.iter_archive(archive) for archive in
+                                       audio_archives["train"].values()],
+                    "local_extracted_archives_paths": local_extracted_archives_paths["train"],
+                    "annotation": annotations["train"],
                     "split": "train"
                 },
             ),
             datasets.SplitGenerator(
                 name=datasets.Split.VALIDATION,
                 gen_kwargs={
-                    "audio_archives": [dl_manager.iter_archive(archive) for archive in dev_audio_archives.values()],
-                    "local_extracted_archives_paths": dl_manager.extract(dev_audio_archives).values() if not dl_manager.is_streaming else [None] * len(dev_audio_archives),
-                    "annotation": dev_annotation,
+                    "audio_archives": [dl_manager.iter_archive(archive) for archive in
+                                       audio_archives["dev"].values()],
+                    "local_extracted_archives_paths": local_extracted_archives_paths["dev"],
+                    "annotation": annotations["dev"],
                     "split": "dev"
                 },
             ),
             datasets.SplitGenerator(
                 name=datasets.Split.TEST,
                 gen_kwargs={
-                    "audio_archives": [dl_manager.iter_archive(archive) for archive in eval_audio_archives.values()],
-                    "local_extracted_archives_paths": dl_manager.extract(eval_audio_archives).values() if not dl_manager.is_streaming else [None] * len(eval_audio_archives),
-                    "annotation": eval_annotation,
+                    "audio_archives": [dl_manager.iter_archive(archive) for archive in
+                                       audio_archives["eval"].values()],
+                    "local_extracted_archives_paths": local_extracted_archives_paths["eval"],
+                    "annotation": annotations["eval"],
                     "split": "eval"
                 },
             ),