Added code to clean up final 3D render surfaces, but local is behind remote tip will fix

app.py

@@ -71,8 +71,8 @@ def resize_image(image_path, max_size=1024):
             img.save(temp_file, format="PNG")
             return temp_file.name
 
-@spaces.GPU  # Increased duration to default 60 seconds
-def generate_3d_model(depth, image_path, focallength_px, simplification_factor=1.0, smoothing_iterations=0, thin_threshold=0):
+@spaces.GPU(duration=30)  # Increased duration to 30 seconds
+def generate_3d_model(depth, image_path, focallength_px, simplification_factor=1.0, smoothing_iterations=0, thin_threshold=0, enable_face_culling=False, culling_threshold=0.1):
     """
     Generate a textured 3D mesh from the depth map and the original image.
     """
@@ -131,6 +131,12 @@ def generate_3d_model(depth, image_path, focallength_px, simplification_factor=1
         # Create the mesh using Trimesh with vertex colors
         mesh = trimesh.Trimesh(vertices=vertices, faces=faces, vertex_colors=colors, process=False)
 
+        # Apply face culling if enabled
+        if enable_face_culling:
+            print(f"Culling faces with normal dot product < {culling_threshold}")
+            mesh = cull_faces_by_normal(mesh, min_dot_product_threshold=culling_threshold)
+            print("After face culling - vertices: {}, faces: {}".format(len(mesh.vertices), len(mesh.faces)))
+
         # Mesh cleaning and improvement steps (only if not using default values)
         if simplification_factor < 1.0 or smoothing_iterations > 0 or thin_threshold > 0:
             print("Original mesh - vertices: {}, faces: {}".format(len(mesh.vertices), len(mesh.faces)))
@@ -172,6 +178,37 @@ def generate_3d_model(depth, image_path, focallength_px, simplification_factor=1
         print(f"Error in generate_3d_model: {str(e)}")
         raise
 
+def cull_faces_by_normal(mesh, min_dot_product_threshold=0.1):
+    """
+    Removes faces from the mesh that are nearly vertical, which often cause 'smearing' artifacts.
+
+    Args:
+        mesh (trimesh.Trimesh): The input mesh.
+        min_dot_product_threshold (float): Faces with normals whose Z-component's absolute
+                                           value is less than this threshold will be removed.
+                                           This effectively removes faces that are nearly vertical.
+                                           A value of 0.1 corresponds to removing faces that are
+                                           within about 84 degrees of being vertical.
+
+    Returns:
+        trimesh.Trimesh: The mesh with offending faces removed.
+    """
+    face_normals = mesh.face_normals
+    # The view vector is along the Z-axis.
+    view_vector = np.array([0, 0, 1])
+    
+    # Calculate the absolute dot product. A small value means the normal is almost perpendicular to the view vector (a 'smear' wall).
+    dot_products = np.abs(np.dot(face_normals, view_vector))
+    
+    # Create a mask to keep faces that are not smear walls.
+    keep_mask = dot_products > min_dot_product_threshold
+    
+    # Apply the mask
+    mesh.update_faces(keep_mask)
+    mesh.remove_unreferenced_vertices()
+    
+    return mesh
+
 def remove_thin_features(mesh, thickness_threshold=0.01):
     """
     Remove thin features from the mesh.
@@ -257,8 +294,8 @@ def predict_depth(input_image):
             os.remove(temp_file)
             print(f"Removed temporary file: {temp_file}")
 
-@spaces.GPU
-def create_3d_model(depth_csv, image_path, focallength_px, simplification_factor, smoothing_iterations, thin_threshold):
+@spaces.GPU(duration=30)
+def create_3d_model(depth_csv, image_path, focallength_px, simplification_factor, smoothing_iterations, thin_threshold, enable_face_culling=False, culling_threshold=0.1):
     try:
         depth = np.loadtxt(depth_csv, delimiter=',')
         
@@ -270,7 +307,8 @@ def create_3d_model(depth_csv, image_path, focallength_px, simplification_factor
         
         view_model_path, download_model_path, texture_path = generate_3d_model(
             depth, image_path, focallength_px, 
-            simplification_factor, smoothing_iterations, thin_threshold
+            simplification_factor, smoothing_iterations, thin_threshold,
+            enable_face_culling, culling_threshold
         )
         print("3D model generated!")
         return view_model_path, download_model_path, texture_path, "3D model created successfully!"
@@ -331,6 +369,10 @@ with gr.Blocks() as iface:
         smoothing_iterations = gr.Slider(minimum=0, maximum=5, value=0, step=1, label="Smoothing Iterations (0 = No smoothing)")
         thin_threshold = gr.Slider(minimum=0, maximum=0.1, value=0, step=0.001, label="Thin Feature Threshold (0 = No thin feature removal)")
     
+    with gr.Row():
+        enable_face_culling = gr.Checkbox(label="Enable Face Culling", value=True)
+        culling_threshold = gr.Slider(minimum=0.0, maximum=1.0, value=0.1, step=0.01, label="Face Culling Threshold")
+
     regenerate_button = gr.Button("Regenerate 3D Model")
     model_status = gr.Textbox(label="3D Model Status")
     
@@ -345,13 +387,13 @@ with gr.Blocks() as iface:
     
     generate_3d_button.click(
         create_3d_model,
-        inputs=[raw_depth_csv, input_image, hidden_focal_length, simplification_factor, smoothing_iterations, thin_threshold],
+        inputs=[raw_depth_csv, input_image, hidden_focal_length, simplification_factor, smoothing_iterations, thin_threshold, enable_face_culling, culling_threshold],
         outputs=[view_3d_model, download_3d_model, download_texture, model_status]
     )
     
     regenerate_button.click(
         create_3d_model,
-        inputs=[raw_depth_csv, input_image, hidden_focal_length, simplification_factor, smoothing_iterations, thin_threshold],
+        inputs=[raw_depth_csv, input_image, hidden_focal_length, simplification_factor, smoothing_iterations, thin_threshold, enable_face_culling, culling_threshold],
         outputs=[view_3d_model, download_3d_model, download_texture, model_status]
     )
 

culling.text

@@ -0,0 +1,7 @@
+1. [x] Add helper `cull_faces_by_normal` in app.py that deletes faces whose normal is close to the camera view axis (|n·[0,0,1]| < min_dot).
+2. [x] Extend `generate_3d_model` with parameter `enable_face_culling=False`; before any mesh post-processing call the helper when enabled.
+3. [x] Propagate the new flag through `create_3d_model` and `regenerate_3d_model` (add param, pass downstream).
+4. [x] Insert a `gr.Checkbox` labelled "Enable Face Culling" in the UI; default True.
+5. [x] Add checkbox to `generate_3d_button` and `regenerate_button` input lists.
+6. [x] Keep backward compatibility (all new parameters have defaults so existing calls still work if checkbox omitted).
+7. [ ] Manual test: run app, toggle checkbox on/off, verify spikes disappear when on and original behaviour when off.